Re: [PATCH v1 04/26] domain_conf: Check NVDIMM UUID in ABI stability

Daniel Henrique Barboza <danielhb413@xxxxxxxxx> · Mon, 30 Nov 2020 16:24:22 -0300

On 11/27/20 12:02 PM, Michal Privoznik wrote:
The UUID is guest visible and thus shouldn't change if we want to
not break guest ABI.

Fixes: 08ed673901bb5b4f419b37bcce9b11d31ce370e6

Thanks for fixing this up.


Reviewed-by: Daniel Henrique Barboza <danielhb413@xxxxxxxxx>


Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
---
  src/conf/domain_conf.c | 6 ++++++
  1 file changed, 6 insertions(+)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index b1534dcc1e..631165c3fa 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -24238,6 +24238,12 @@ virDomainMemoryDefCheckABIStability(virDomainMemoryDefPtr src,
                               "source NVDIMM readonly flag"));
              return false;
          }
+
+        if (memcmp(src->uuid, dst->uuid, VIR_UUID_BUFLEN) != 0) {
+            virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
+                           _("Target NVDIMM UUID doesn't match source NVDIMM"));
+            return false;
+        }
      }
  
      return virDomainDeviceInfoCheckABIStability(&src->info, &dst->info);








