On Wed, 25 Nov 2020 12:06:47 +0100
Thomas Huth <thuth@xxxxxxxxxx> wrote:
> On s390x, devices are attached to the channel IO subsytem by default,
s/attached to the channel IO subsystem/accessed via the channel subsystem/
> so we need to look up the devices via their CCW address there instead
> of using PCI.
>
> This fixes "virsh domfsinfo" on s390x for virtio-block devices (the first
> attempt from commit f8333b3b0a7 did it in the wrong way, reporting the
> device name on the guest side instead of the target name on the host side).
>
> Fixes: f8333b3b0a ("qemu: Fix domfsinfo for non-PCI device information ...")
> Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1858771
> Signed-off-by: Thomas Huth <thuth@xxxxxxxxxx>
> ---
> src/conf/domain_conf.c | 10 +++++++++-
> src/conf/domain_conf.h | 2 ++
> src/qemu/qemu_driver.c | 8 +++++---
> 3 files changed, 16 insertions(+), 4 deletions(-)
Keeping my limited libvirt knowledge in mind:
Reviewed-by: Cornelia Huck <cohuck@xxxxxxxxxx>
