(This is the most inconsequential of inconsequential typos, but the incongruity was bugging me.) When virfirewalltest.c was first written in commit 3a0ca7de51 (March 2013), a conditional accidentally tested for "ipv4" instead of "ipv6". Since the file ended up only testing ipv4 rules, this has never made any difference in practice, but I'm making some other changes in this file and just couldn't let it stand :-) Signed-off-by: Laine Stump <laine@xxxxxxxxxx> --- tests/virfirewalltest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/virfirewalltest.c b/tests/virfirewalltest.c index dc631dfc5d..872ee3ed17 100644 --- a/tests/virfirewalltest.c +++ b/tests/virfirewalltest.c @@ -128,7 +128,7 @@ VIR_MOCK_WRAP_RET_ARGS(g_dbus_connection_call_sync, if (fwBuf) { if (STREQ(type, "ipv4")) virBufferAddLit(fwBuf, IPTABLES_PATH); - else if (STREQ(type, "ipv4")) + else if (STREQ(type, "ipv6")) virBufferAddLit(fwBuf, IP6TABLES_PATH); else virBufferAddLit(fwBuf, EBTABLES_PATH); -- 2.28.0