Re: [PATCH] virDomainAuthorizedSSHKeysSet: Use uint for @nkeys

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 23, 2020 at 01:15:28PM +0100, Michal Privoznik wrote:
> When introducing the API I've mistakenly used 'int' type for
> @nkeys argument which does nothing more than tells the API how
> many items there are in @keys array. Obviously, negative values
> are not expected and therefore 'unsigned int' should have been
> used.
> 
> Reported-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
>  include/libvirt/libvirt-domain.h | 2 +-
>  src/driver-hypervisor.h          | 2 +-
>  src/libvirt-domain.c             | 4 ++--
>  src/qemu/qemu_driver.c           | 2 +-
>  src/remote/remote_driver.c       | 2 +-
>  5 files changed, 6 insertions(+), 6 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux