The function is supposed to add a feature to a CPU definition, let's name it virCPUDefAddFeatureInternal. The behavior in case the feature is already present in the CPU def is configurable and we will soon add a new option to not do anything in that case, which wouldn't really work well with the current *Update* name. Signed-off-by: Jiri Denemark <jdenemar@xxxxxxxxxx> --- src/conf/cpu_conf.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c index 5cf7716b12..55a7925d8a 100644 --- a/src/conf/cpu_conf.c +++ b/src/conf/cpu_conf.c @@ -858,10 +858,10 @@ virCPUDefFormatBuf(virBufferPtr buf, } static int -virCPUDefUpdateFeatureInternal(virCPUDefPtr def, - const char *name, - int policy, - bool update) +virCPUDefAddFeatureInternal(virCPUDefPtr def, + const char *name, + int policy, + bool update) { virCPUFeatureDefPtr feat; @@ -898,7 +898,7 @@ virCPUDefUpdateFeature(virCPUDefPtr def, const char *name, int policy) { - return virCPUDefUpdateFeatureInternal(def, name, policy, true); + return virCPUDefAddFeatureInternal(def, name, policy, true); } int @@ -906,7 +906,7 @@ virCPUDefAddFeature(virCPUDefPtr def, const char *name, int policy) { - return virCPUDefUpdateFeatureInternal(def, name, policy, false); + return virCPUDefAddFeatureInternal(def, name, policy, false); } -- 2.29.2