On Fri, Nov 20, 2020 at 03:31:39PM +0100, Andrea Bolognani wrote: > On Fri, 2020-11-20 at 13:58 +0100, Martin Kletzander wrote: > > On Fri, Nov 20, 2020 at 12:24:38PM +0100, Andrea Bolognani wrote: > > > While I would love the simplification such an approach would yield, > > > I have to point out that there is at least one advantage to checking > > > for the availability of commands at build time, even if those > > > commands will only ever be invoked at runtime: it makes it obvious > > > those commands are going to be needed later on. > Lastly, if we stopped looking for commands at build time we would be > enabling features that can, in reality, never work: iscsiadm, for > example, is Linux-only, but if we removed the corresponding build > time check we would start building the iscsi storage driver, which > requires the command to be present, on FreeBSD and macOS too. This > would be incredibly misleading and, well, just plain wrong IMHO. If you remove the iscsiadm check, it has to be replaced with an os == linux check in meson instead. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
