Re: [libvirt PATCH 1/2] qemu: json: check return value of virJSONValueObjectGetBoolean

Peter Krempa <pkrempa@xxxxxxxxxx> · Fri, 20 Nov 2020 15:11:10 +0100

On Fri, Nov 20, 2020 at 15:08:31 +0100, JÃ¡n Tomko wrote:
> On a Friday in 2020, Peter Krempa wrote:
> > On Fri, Nov 20, 2020 at 14:46:06 +0100, JÃ¡n Tomko wrote:
> > > Signed-off-by: JÃ¡n Tomko <jtomko@xxxxxxxxxx>
> > > Fixes: 7555a554706e8a6d492804debbacfaae9f5d8b05
> > > ---
> > >  src/qemu/qemu_monitor_json.c | 6 ++++--
> > >  1 file changed, 4 insertions(+), 2 deletions(-)
> > 
> > See the discussion at:
> > 
> > https://www.redhat.com/archives/libvir-list/2020-November/msg00859.html
> > 
> 
> The discussion revolves around silencing coverity.
> 
> This patch aims to fix the bug.

Well, would you care to explain the bug then? Ideally in the commit
message of all places. 