On Thu, 2020-11-19 at 11:03 -0500, Laine Stump wrote: > On 11/19/20 10:36 AM, Andrea Bolognani wrote: > > Andrea Bolognani (3): > > conf: Write network config to disk after generating UUID > > network: Drop UUID handling for default network > > spec: Drop UUID handling for default network > > Reviewed-by: Laine Stump <laine@xxxxxxxxxx> > > for the series. Thanks, pushed now. > We should change the other drivers that have uuids so that they also > save if the uuid was added during parse. If that sounds boring to you, > then I can put it on a list somewhere. I can't guarantee that will mean > that it actually gets done though :-) I'm going to take a stab at that, but I felt like there was a very strong case for introducing this behavior for networks specifically because 1) we already have it for MAC addresses and 2) we also already do it for nwfilters, the other libvirt object for which we know for sure we're going to be dropping configuration files into /etc/libvirt at install time. While I think extending this behavior to all libvirt objects is the way to go, I can also see that being a more controversial change, so I didn't to tie the two together and risk this never getting merged because of that :) -- Andrea Bolognani / Red Hat / Virtualization
