Re: [PATCH] util: convert char pointers to use g_autofree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I spent a significant chunk of time trying to get `git send-email` working but struggled to get the tool to work on my computer.

I instead used the `Email Patch` feature in GitLab to format the patch as an email.

Since the formatting is wrong, I may have someone submit the patch on my behalf.

On Wed, Nov 18, 2020 at 11:46 AM Michal Privoznik <mprivozn@xxxxxxxxxx> wrote:
On 11/17/20 9:45 PM, Barrett J Schonefeld wrote:
>>From 82f992c7ff4ef59682f42c863fca242dd84208f9 Mon Sep 17 00:00:00 2001
> From: Barrett Schonefeld <bschoney@xxxxxxxxxx>
> Date: Mon, 9 Nov 2020 16:07:25 -0600
> Subject: [PATCH] util: convert char pointers to use g_autofree
>
> additional conversions to the GLib API in src/util per issue #11.
>
> Related issue: https://gitlab.com/libvirt/libvirt/-/issues/11
>
> Signed-off-by: Barrett Schonefeld <bschoney@xxxxxxxxxx>
> ---
>   src/util/vircgroupv1.c           |  3 +-
>   src/util/virdnsmasq.c            | 43 ++++++++-------------
>   src/util/virfile.c               |  9 ++---
>   src/util/virhostcpu.c            |  4 +-
>   src/util/virlockspace.c          |  6 +--
>   src/util/virlog.c                | 12 ++----
>   src/util/virmacmap.c             |  3 +-
>   src/util/virnetdevbandwidth.c    | 48 ++++++++---------------
>   src/util/virresctrl.c            | 25 ++++--------
>   src/util/virrotatingfile.c       | 11 ++----
>   src/util/virscsihost.c           | 25 +++++-------
>   src/util/virsecret.c             | 14 +++----
>   src/util/virstorageencryption.c  | 19 +++------
>   src/util/virstoragefilebackend.c |  4 +-
>   src/util/virsysinfo.c            | 18 +++------
>   src/util/viruri.c                |  7 +---
>   src/util/virutil.c               | 66 +++++++++++---------------------
>   src/util/virvhba.c               | 57 ++++++++++-----------------
>   src/util/virxml.c                |  7 +---
>   19 files changed, 130 insertions(+), 251 deletions(-)


I'm sorry, I can't apply this patch, it is corrupted. Looks like you've
wrapped lines. Does 'git send-email' not work for you? Because that is
the recommended way to send patches.

https://libvirt.org/submitting-patches.html

Michal


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux