On Tue, 2020-11-17 at 17:02 +0800, yangshaojun19@xxxxxxx wrote:
> From: yangshaojun <yangshaojun@xxxxxxxxxxxxxx>
>
> Signed-off-by: yangshaojun <yangshaojun@xxxxxxxxxxxxxx>
Both the git authorship information and the Signed-off-by tag should
contain information in the form
FirstName LastName <email@address>
Please update them.
> +++ b/src/cpu_map/arm_Phytium.xml
> @@ -0,0 +1,10 @@
> +<cpus>
> + <model name='FT-2000+'>
> + <vendor name='Phytium'/>
> + <pvr value='0x662'/>
> + </model>
> + <model name='Tengyun-S2500'>
> + <vendor name='Phytium'/>
> + <pvr value='0x663'/>
> + </model>
> +</cpus>
Looking at how other CPU models are handled, there's usually a single
CPU model per XML file, so this should probably be
# src/cpu_map/arm_FT-2000plus.xml
<cpus>
<model name='FT-2000+'>
<vendor name='Phytium'/>
<pvr value='0x662'/>
</model>
<cpus>
# src/cpu_map/arm_Tengyun-S2500.xml
<cpus>
<model name='Tengyun-S2500'>
<vendor name='Phytium'/>
<pvr value='0x663'/>
</model>
<cpus>
with both files being included by src/cpu_map/index.xml of course.
More importantly, you need to list these files in the cpumap_data
list defined in src/cpu_map/meson.build, or they will not be
installed on the target system.
Sorry for not pointing up these issues the first time around.
Everything else looks good.
--
Andrea Bolognani / Red Hat / Virtualization
