Re: [libvirt PATCH 08/11] remote_driver: remove unreachable cleanup code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 16, 2020 at 16:38:55 +0100, Pavel Hrdina wrote:
> In the cleanup section @info_ret will always be NULL.

The two instances of 'info_ret' are actually completely distinct
variables of distinct types. That's quite sneaky and the commit message
is deceiving.


> Signed-off-by: Pavel Hrdina <phrdina@xxxxxxxxxx>
> ---
>  src/remote/remote_driver.c | 18 ++++--------------
>  1 file changed, 4 insertions(+), 14 deletions(-)

If you split the commit:

Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx>




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux