On Sun, Nov 15, 2020 at 07:19:24PM -0500, Laine Stump wrote: > On 11/15/20 3:43 PM, Andrea Bolognani wrote: > > We are generating a fresh UUID and storing it in the XML for the > > default network, but this is unnecessary because the network > > driver will automatically generate one if it's missing from the > > XML; > > > But that automatically generated uuid will not be stored in the original xml > in /etc/libvirt, so a new and different uuid will be generated every time > libvirt is restarted. > > > I don't know if the solution to this is to modify libvirt so that it > rewrites the XML for a network if it has to auto-generate any attributes[*], > or to put a canned/static uuid value in the installed xml, or just to > declare that we don't care if the uuid changes from one run of libvirtd to > the next. But definitely these patches change behavior, so we probably need > to point that out and maybe discuss it. We definitely should not be changing UUID on every startup, so IMHO this patch should not be applied. I'm not seeing much point in creating some new solution in libvirtd to replace something which already works, unless there's actually some real problem reported which isn't mentioned in this commit message. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
