On 11/11/20 3:38 AM, Michal Privoznik wrote: > There are two type of vhostuser ports: > > dpdkvhostuser - OVS creates the socket and QEMU connects to it > dpdkvhostuserclient - QEMU creates the socket and OVS connects to it > > But of course ovs-vsctl syntax for fetching ifname is different. > So far, we've implemented the former. The lack of implementation > for the latter means that we are not detecting the interface name > and thus not reporting it in domain XML, or failing to get > interface statistics. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1767013 > > Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> > --- > src/qemu/qemu_command.c | 1 + > src/qemu/qemu_hotplug.c | 1 + > src/util/virnetdevopenvswitch.c | 60 +++++++++++++++++++++++---------- > src/util/virnetdevopenvswitch.h | 1 + > tests/qemuxml2argvmock.c | 1 + > 5 files changed, 46 insertions(+), 18 deletions(-) > [...] > diff --git a/src/util/virnetdevopenvswitch.h b/src/util/virnetdevopenvswitch.h > index c9ea592058..5cd1d22ae3 100644 > --- a/src/util/virnetdevopenvswitch.h > +++ b/src/util/virnetdevopenvswitch.h > @@ -61,6 +61,7 @@ int virNetDevOpenvswitchInterfaceGetMaster(const char *ifname, char **master) > ATTRIBUTE_NONNULL(1) G_GNUC_WARN_UNUSED_RESULT; > > int virNetDevOpenvswitchGetVhostuserIfname(const char *path, > + bool server, > char **ifname) > ATTRIBUTE_NONNULL(2) G_GNUC_WARN_UNUSED_RESULT G_GNUC_NO_INLINE; ^^ A coverity build breaker... s/(2)/(3) will resolve. John
