Re: [PATCH 2/6] qemu: conf: Clarify default of "vnc_tls_x509_verify"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/13/20 4:45 PM, Daniel P. Berrangé wrote:
On Fri, Nov 13, 2020 at 04:38:06PM +0100, Michal Privoznik wrote:
On 11/13/20 4:01 PM, Peter Krempa wrote:
If both "vnc_tls_x509_verify" and "default_tls_x509_verify" are missing
from the config file the client certificate validation is disabled. VNC
provides a layer of authentication so client certificate validation is
not strictly required.

Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
---
   src/qemu/qemu.conf | 3 ++-
   1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf
index 6f9d940477..f40963ce48 100644
--- a/src/qemu/qemu.conf
+++ b/src/qemu/qemu.conf
@@ -119,7 +119,8 @@
   # CA in the vnc_tls_x509_cert_dir (or default_tls_x509_cert_dir).
   #
   # If this option is not supplied, it will be set to the value of
-# "default_tls_x509_verify".
+# "default_tls_x509_verify". If "default_tls_x509_verify" is not supplied either

No native speaker, but perhaps s/either/neither/? Applies for next patches
too.

That wouldn't be right - what's there now is fine.

Okay, coming from a language that has double negatives so I'm never sure :-)

Thanks for clarification.

Michal




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux