On a Monday in 2020, Michal Privoznik wrote:
The viridentitytest tests our viridentity module which is compiled on all platforms and OSes. There is no need to have SELinux secdriver as individual test cases are skipped if SELinux is missing. Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> --- Successfully build here: https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/213586713 While technically this is a v2 of: https://www.redhat.com/archives/libvir-list/2020-November/msg00308.html it's implementing completely different approach and thus I did not mark it as v2. tests/meson.build | 2 +- tests/viridentitytest.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/meson.build b/tests/meson.build index 8decdfa20c..9f0051303d 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -312,6 +312,7 @@ tests += [ { 'name': 'virfirewalltest' }, { 'name': 'virhostcputest', 'link_whole': [ test_file_wrapper_lib ] }, { 'name': 'virhostdevtest' }, + { 'name': 'viridentitytest' },
This seems to drop the check for WITH_ATTR which was added in:
commit cdc5f3f1a3a960cbc988ad6a21078f135c936457
tests: build viridentitytest only WITH_ATTR.
Was it ever needed?
{ 'name': 'viriscsitest' },
{ 'name': 'virkeycodetest' },
{ 'name': 'virkmodtest' },
Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx> Jano
Attachment:
signature.asc
Description: PGP signature
