Re: [PATCH libvirt v2 01/11] nodedev: detect AP card device

[Shalini Chellathurai Saroja <shalini@xxxxxxxxxxxxx>]

Hi Jonathon,

Thank you for the quick review:-)

On 11/12/20 5:27 PM, Jonathon Jongsma wrote:

> > +  <define name='address'>
> > +    <element name='address'>
> > +      <attribute name='domain'><ref name='hexuint'/></attribute>
> > +      <attribute name='bus'><ref name='hexuint'/></attribute>
> > +      <attribute name='slot'><ref name='hexuint'/></attribute>
> > +      <attribute name='function'><ref name='hexuint'/></attribute>
> >       
> It seems that you're unnecessarily changing double-quotes to
> single-quotes here, which adds spurious changes to the diff. The rest of
> the file uses double-quotes. Let's stick with that.
>     
    Sure.
> >      </element>
> >    </define>
> >  
> > @@ -716,4 +726,16 @@
> >      </element>
> >    </define>
> >  
> > +  <define name="apAdapterRange">
> > +    <choice>
> > +      <data type="string">
> > +        <param name="pattern">(0x)?[0-9a-fA-F]{1,2}</param>
> > +      </data>
> > +      <data type="int">
> > +        <param name="minInclusive">0</param>
> > +        <param name="maxInclusive">255</param>
> > +      </data>
> > +    </choice>
> > +  </define>
> >       
> As far as I can tell, this is identical to the definition of the
> 'uint8' type in basictypes.rng. Is there a reason for defining a
> different type?
>
>     
    Yes, In definition apAdapterRange, the prefix '0x' is optional.
-- 
Kind regards
Shalini Chellathurai Saroja
Linux on Z and Virtualization Development
Dept 1419
Vorsitzende des Aufsichtsrats: Gregor Pillen
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294