On Thu, 2020-11-12 at 18:53 -0300, Daniel Henrique Barboza wrote: > On 11/12/20 8:28 AM, Michal Privoznik wrote: > > On 11/11/20 11:07 PM, Daniel Henrique Barboza wrote: > > > NEWS.rst | 14 +++ > > > src/conf/domain_conf.c | 25 ++++- > > > src/conf/domain_conf.h | 2 +- > > > src/libvirt_private.syms | 2 +- > > > src/qemu/qemu_domain.c | 106 +++++++----------- > > > src/qemu/qemu_domain.h | 2 - > > > src/qemu/qemu_hotplug.c | 9 +- > > > tests/qemuxml2argvdata/hugepages-nvdimm.xml | 2 +- > > > .../memory-hotplug-nvdimm-access.xml | 2 +- > > > .../memory-hotplug-nvdimm-align.xml | 2 +- > > > .../memory-hotplug-nvdimm-label.xml | 2 +- > > > .../memory-hotplug-nvdimm-pmem.xml | 2 +- > > > .../memory-hotplug-nvdimm-readonly.xml | 2 +- > > > .../memory-hotplug-nvdimm.xml | 2 +- > > > .../memory-hotplug-ppc64-nonuma.args | 2 +- > > > tests/qemuxml2argvdata/pages-dimm-discard.xml | 2 +- > > > .../memory-hotplug-dimm.xml | 4 +- > > > 17 files changed, 92 insertions(+), 90 deletions(-) > > > > Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx> > > Thanks for the review! > > > but perhaps you want Andrea to look into it too. > > Of course. Andrea, not sure if you want to review the whole series so here's > the gist: we already have the ppc64 NVDIMM alignment being done in PostParse time, > so I started to move all ppc64 memory module alignment to PostParse as well. In > the end I figured I could also move the alignment for x86 as well. Do you see any > potential problem with this design change? I'll take a look and let you know :) -- Andrea Bolognani / Red Hat / Virtualization
