Re: [PATCH 00/28] a bunch of domain_conf cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On Nov 9, 2020, at 9:43 AM, Michal Privoznik <mprivozn@xxxxxxxxxx> wrote:
> 
> Nice cleanup. But as I say in 03/28 I think we might want glib adoption to be done in bigger chunks. Usually we rewrite VIR_ALLOC/VIR_REALLOC_N -> g_new0()/g_renew() in one patch (might be coupled with g_free() except VIR_FREE() resets the pointer to NULL and g_free() doesn't do that so I'm not really a fan of g_free()), then g_strdup() in another path, and so on.

I had thought that g_free() was a drop-in replacement for VIR_FREE() 
based on other earlier commits that I had seen. You can drop the 
g_free() commits from this series if everything else looks good.

-- 
Matt





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux