Re: [libvirt] [PATCH 2/4] qemu: Make SetVcpu command hotplug only

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/15/2010 06:09 AM, Daniel P. Berrange wrote:
> On Fri, Feb 12, 2010 at 10:32:15AM -0500, Cole Robinson wrote:
>> Similar to the Set*Mem commands, this implementation was bogus and
>> misleading. Make it clear this is a hotplug only operation, and that the
>> hotplug piece isn't even implemented.
>>
>> Also drop the overkill maxvcpus validation: we don't perform this check
>> at XML define time so clearly no one is missing it, and there is
>> always the risk that our info will be out of date, possibly preventing
>> legitimate CPU values.
>> ---
>>  src/qemu/qemu_driver.c |   42 +++++++-----------------------------------
>>  1 files changed, 7 insertions(+), 35 deletions(-)
>>

> 
> ACK
> 
> Daniel

Thanks, pushed now.

- Cole

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]