On Thu, Nov 5, 2020 at 10:33 PM Matt Coleman <mcoleman@xxxxxxxxx> wrote: > > Most of this is making functions void that unnecessarily return an int. > It also includes some conversion to GLib. > > Feel free to squash related commits, if you'd like. I left them separate > to make it easier to review. > > Matt Coleman (28): > domain_conf: make virDomainDiskSetDriver() void > domain_conf: make virDomainPostParseCheckISCSIPath() void > domain_conf: use g_free() in virDomainPostParseCheckISCSIPath() > domain_conf: make virDomainHostdevAssignAddress() void > domain_conf: make virDomainChr/RNG/Video/VsockDefPostParse() and > virDomainNVRAMDefFormat() void > domain_conf: make virDomainDeviceInfoFormat() void > domain_conf: make virDomainGraphicsDefParseXMLEGLHeadless() void > domain_conf: make virDomainLeaseDefFormat() void > domain_conf: make virDomainDiskSourceFormatNetwork() void > domain_conf: make virDomainDiskDefFormatIotune() void > domain_conf: make virDomainDiskDefFormatDriver() void > domain_conf: make virDomainControllerDriverFormat() void > domain_conf: make virDomainVirtioNetGuestOpts/HostOpts/DriverFormat() > void > domain_conf: make virDomainRedirFilterDefFormat() void > domain_conf: make virDomainIOMMUDefFormat() void > domain_conf: make virDomainDefFormatBlkiotune() void > domain_conf: make virDomainChrSourceDefFormat() void > domain_conf: make virDomainDiskSetBlockIOTune() void > domain_conf: use g_free in virDomainDiskSetBlockIOTune() > domain_conf: use g_renew in virDomainDiskInsert() and > virDomainControllerInsert() > domain_conf: make virDomainDiskInsert() void > domain_conf: make virDomainControllerInsert() void > domain_conf: use g_renew in virDomainLeaseInsertPreAlloc() > domain_conf: make virDomainLeaseInsertPreAlloc() void > domain_conf: make virDomainLeaseInsert() void > domain_conf: make virDomainPanicDefFormat() void > domain_conf: make virDomainShmemDefFormat() void > domain_conf: make virDomainVsockDefFormat() void > > src/conf/domain_conf.c | 349 ++++++++++++++------------------------- > src/conf/domain_conf.h | 21 +-- > src/libxl/libxl_conf.c | 5 +- > src/libxl/libxl_domain.c | 5 +- > src/libxl/libxl_driver.c | 9 +- > src/libxl/xen_xl.c | 12 +- > src/libxl/xen_xm.c | 10 +- > src/lxc/lxc_driver.c | 3 +- > src/qemu/qemu_domain.c | 5 +- > src/qemu/qemu_driver.c | 15 +- > src/qemu/qemu_hotplug.c | 3 +- > src/test/test_driver.c | 3 +- > src/vz/vz_sdk.c | 9 +- > tests/qemublocktest.c | 5 +- > 14 files changed, 158 insertions(+), 296 deletions(-) > > -- > 2.27.0 > > Series LGTM. Reviewed-by: Neal Gompa <ngompa13@xxxxxxxxx> -- 真実はいつも一つ！/ Always, there's only one truth!
