This function always returns zero, so it might as well be void. Signed-off-by: Matt Coleman <matt@xxxxxxxxx> --- src/conf/domain_conf.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 30aee44445..c106de7f81 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -25317,7 +25317,7 @@ virDomainDiskSourceFormatNetworkCookies(virBufferPtr buf, } -static int +static void virDomainDiskSourceFormatNetwork(virBufferPtr attrBuf, virBufferPtr childBuf, virStorageSourcePtr src, @@ -25375,8 +25375,6 @@ virDomainDiskSourceFormatNetwork(virBufferPtr attrBuf, if (src->timeout) virBufferAsprintf(childBuf, "<timeout seconds='%llu'/>\n", src->timeout); - - return 0; } @@ -25488,9 +25486,7 @@ virDomainDiskSourceFormat(virBufferPtr buf, break; case VIR_STORAGE_TYPE_NETWORK: - if (virDomainDiskSourceFormatNetwork(&attrBuf, &childBuf, - src, flags) < 0) - return -1; + virDomainDiskSourceFormatNetwork(&attrBuf, &childBuf, src, flags); break; case VIR_STORAGE_TYPE_VOLUME: -- 2.27.0