Re: [PATCH] domain_conf: make virDomainDiskSetSource() void

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On Nov 5, 2020, at 3:43 PM, Matt Coleman <mcoleman@xxxxxxxxx> wrote:
> 
> I also could go a bit further with this function's rewrite: the tmp 
> variable isn't actually necessary any longer since g_strdup() will 
> abort on failure. So, the function might as well be just two lines: 
> g_free() followed by g_strdup().

I realize that I was wrong about this because it does get called with 
src == def->src->path, which results in it attempting to dup 
already-freed memory.

-- 
Matt




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux