Re: [PATCH] domain_conf: make virDomainDiskSetSource() void

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On a Thursday in 2020, Matt Coleman wrote:
The function only returns zero or aborts, so it might as well be void.
This has the added benefit of simplifying the code that calls it.

Signed-off-by: Matt Coleman <matt@xxxxxxxxx>
---
src/conf/domain_conf.c   |  3 +--
src/conf/domain_conf.h   |  3 +--
src/libxl/libxl_driver.c |  6 ++----
src/libxl/xen_xl.c       |  3 +--
src/libxl/xen_xm.c       | 13 ++++---------
src/lxc/lxc_controller.c | 13 ++-----------
src/vbox/vbox_common.c   |  6 +-----
src/vmx/vmx.c            | 36 ++++++++++++------------------------
src/vz/vz_sdk.c          |  4 ++--
9 files changed, 26 insertions(+), 61 deletions(-)


Nice cleanup.

Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>

Jano

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux