[PATCH v2 01/12] virhashtest: testHashGetItems: Remove test case for sorting by value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Upcoming patch will rewrite virHashGetItems to remove the sorting
function since the prevalent mode is to order by keys.

Remove the test for it.

Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
---
 tests/virhashtest.c | 19 -------------------
 1 file changed, 19 deletions(-)

diff --git a/tests/virhashtest.c b/tests/virhashtest.c
index ad50aae003..8cc3109929 100644
--- a/tests/virhashtest.c
+++ b/tests/virhashtest.c
@@ -368,13 +368,6 @@ testHashGetItemsCompKey(const virHashKeyValuePair *a,
     return strcmp(a->key, b->key);
 }

-static int
-testHashGetItemsCompValue(const virHashKeyValuePair *a,
-                          const virHashKeyValuePair *b)
-{
-    return strcmp(a->value, b->value);
-}
-
 static int
 testHashGetItems(const void *data G_GNUC_UNUSED)
 {
@@ -416,18 +409,6 @@ testHashGetItems(const void *data G_GNUC_UNUSED)
     }
     VIR_FREE(array);

-    if (!(array = virHashGetItems(hash, testHashGetItemsCompValue)) ||
-        STRNEQ(array[0].key, "c") ||
-        STRNEQ(array[0].value, "1") ||
-        STRNEQ(array[1].key, "b") ||
-        STRNEQ(array[1].value, "2") ||
-        STRNEQ(array[2].key, "a") ||
-        STRNEQ(array[2].value, "3") ||
-        array[3].key || array[3].value) {
-        VIR_TEST_VERBOSE("\nfailed to get items with value sort");
-        goto cleanup;
-    }
-
     ret = 0;

  cleanup:
-- 
2.26.2




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux