On Mon, Nov 02, 2020 at 09:14:22AM +0100, Christian Ehrhardt wrote: > On Thu, Oct 29, 2020 at 5:07 PM Dario Faggioli <dfaggioli@xxxxxxxx> wrote: > > > This patch maps /domain/cpu/maxphysaddr into -cpu parameters: > > > > - <maxphysaddr mode='passthrough'/> becomes host-phys-bits=on > > - <maxphysaddr mode='emualte' bits='42'/> becomes phys-bits=42 > > > > I can't thank you enough Dario for starting this, > I have waited for this quite a while and never found the time for it myself > :-/ > > Looking at my todo notes I wondered if while touching it we should right > away also > add host-phys-bits-limit in the same spot? > See https://git.qemu.org/?p=qemu.git;a=commit;h=258fe08bd341d I'm not convinced we actally need it in libvirt. Assuming we report the host phys bits in the capabilities XML, apps can already achieve this functionality with the mode=emulate bits=NN settings by populating NN based on the capabilities XML. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|