Re: [PATCH 0/8] more Hyper-V code cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 2, 2020 at 7:22 PM Matt Coleman <mcoleman@xxxxxxxxx> wrote:
>
> Here's a draft GitLab MR if you'd prefer to review the changes there:
> https://gitlab.com/iammattcoleman/libvirt/-/merge_requests/5
>
> Matt Coleman (8):
>   hyperv: g_autofree username and password in hypervConnectOpen()
>   hyperv: remove spaces after hypervObject* casts
>   hyperv: WMI class list function general cleanup
>   hyperv: move hypervGetWmiClass to hyperv_wmi.h
>   hyperv: move hypervGetProcSDByVSSDInstanceId to hyperv_wmi.c
>   hyperv: consistent names for SettingData functions
>   hyperv: minor formatting fix in hyperv_wmi.h
>   hyperv: call openwsman's ws_serializer_free_mem
>
>  src/hyperv/hyperv_driver.c | 87 ++++++++++----------------------------
>  src/hyperv/hyperv_wmi.c    | 63 +++++++++++++++------------
>  src/hyperv/hyperv_wmi.h    | 45 ++++++++++++++------
>  3 files changed, 89 insertions(+), 106 deletions(-)
>
> --
> 2.27.0
>
>

Series LGTM.

Reviewed-by: Neal Gompa <ngompa13@xxxxxxxxx>


-- 
真実はいつも一つ!/ Always, there's only one truth!





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux