[PATCH] cpu_ppc64: compare CPU function is ignoring return value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Function to compare CPU on 64-bit PowerPC is ignoring the flag to avoid 
failure in case of CPUs (host and guest) are incompatible. Basically, the 
function is returning -1 even if it is set to continue.

Signed-off-by: Julio Faracco <jcfaracco@xxxxxxxxx>
---
 src/cpu/cpu_ppc64.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c
index 2fedcd25da..23ea5a6a3e 100644
--- a/src/cpu/cpu_ppc64.c
+++ b/src/cpu/cpu_ppc64.c
@@ -517,7 +517,7 @@ virCPUppc64Compare(virCPUDefPtr host,
                    virCPUDefPtr cpu,
                    bool failIncompatible)
 {
-    virCPUCompareResult ret;
+    virCPUCompareResult ret = -1;
     g_autofree char *message = NULL;
 
     if (!host || !host->model) {
@@ -528,7 +528,7 @@ virCPUppc64Compare(virCPUDefPtr host,
             VIR_WARN("unknown host CPU");
             ret = VIR_CPU_COMPARE_INCOMPATIBLE;
         }
-        return -1;
+        return ret;
     }
 
     ret = ppc64Compute(host, cpu, NULL, &message);
-- 
2.25.1




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux