Thanks for the reminding. I would fix that in my V3 patches. 在 2020/10/26 14:24, Peter Krempa 写道: > On Sun, Oct 25, 2020 at 10:35:03 +0800, Hao Wang wrote: >> Hi Daniel, >> >> For the warning in your compiling -- "error: ‘qemuMonitorJSONExtractDirtyRateInfo’ defined but not used [-Werror=unused-function]": >> >> " qemuMonitorJSONExtractDirtyRateInfo" would be called by function "qemuMonitorJSONQueryDirtyRate" in [PATCH 3/7]. >> So please apply all the serial of patches before your compiling. Thanks! > > Note that according to our contributor guidelines [1] a patchset must > compile cleanly and pass all testsuite after every single patch. > > Please reorganize your series such that this can be achieved. Also note > that squashing all patches into 1 is not acceptable. Patchet must be > logically split into separable chunks. > > [1] https://libvirt.org/hacking.html#preparing-patches > > . >
