On Thu, Oct 22, 2020 at 11:35:04AM +0200, Peter Krempa wrote: > All users of virHashTable pass strings as the name/key of the entry. > Make this an official requirement by turning the variables to 'const > char *'. > > For any other case it's better to use glib's GHashTable. > > Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx> > --- > src/conf/nwfilter_params.c | 2 +- > src/conf/virchrdev.c | 2 +- > src/conf/virdomainmomentobjlist.c | 6 ++-- > src/conf/virdomainobjlist.c | 12 ++++---- > src/conf/virinterfaceobj.c | 10 +++--- > src/conf/virnetworkobj.c | 16 +++++----- > src/conf/virnodedeviceobj.c | 18 +++++------ > src/conf/virnwfilterbindingobjlist.c | 4 +-- > src/conf/virsecretobj.c | 8 ++--- > src/conf/virstorageobj.c | 22 +++++++------- > src/hypervisor/virclosecallbacks.c | 2 +- > src/locking/lock_daemon.c | 2 +- > src/nwfilter/nwfilter_dhcpsnoop.c | 6 ++-- > src/nwfilter/nwfilter_gentech_driver.c | 6 ++-- > src/qemu/qemu_blockjob.c | 2 +- > src/qemu/qemu_capabilities.c | 2 +- > src/qemu/qemu_checkpoint.c | 2 +- > src/qemu/qemu_domain.c | 6 ++-- > src/qemu/qemu_domain.h | 2 +- > src/qemu/qemu_process.c | 2 +- > src/qemu/qemu_snapshot.c | 4 +-- > src/rpc/virnetdaemon.c | 14 ++++----- > src/test/test_driver.c | 6 ++-- > src/util/virfilecache.c | 2 +- > src/util/virhash.c | 42 +++++++++++++------------- > src/util/virhash.h | 32 ++++++++++---------- > src/util/virlockspace.c | 2 +- > src/util/virmacmap.c | 4 +-- > tests/qemumonitorjsontest.c | 2 +- > tests/qemusecuritymock.c | 8 ++--- > tests/virhashtest.c | 10 +++--- > 31 files changed, 129 insertions(+), 129 deletions(-) Reviewed-by: Pavel Hrdina <phrdina@xxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature
