[PATCH 01/15] virCgroupKillRecursive: Return -1 on failure condition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



virCgroupKillRecursive sneakily initializes 'ret' to 0 rather than the
usual -1. 401030499bf moved an error condition but didn't actually
modify 'ret' return the proper error code.

Fixes: 401030499bf
Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
---
 src/util/vircgroup.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c
index d408e3366f..5f4cb01bc0 100644
--- a/src/util/vircgroup.c
+++ b/src/util/vircgroup.c
@@ -2591,6 +2591,7 @@ virCgroupKillRecursive(virCgroupPtr group, int signum)
     if (!backends || !backendAvailable) {
         virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                        _("no cgroup backend available"));
+        ret = -1;
         goto cleanup;
     }

-- 
2.26.2




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux