Re: [libvirt PATCH] rpm: disable LTO in Fedora 34

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/21/20 8:19 AM, Daniel P. Berrangé wrote:
A binutils change has caused breakage when linking the tests

/usr/bin/ld: tests/libtest_qemu_driver.so: undefined reference to `__open_missing_mode'

This is probably a regression in binutils, so disable LTO until we get
more clarity on the root cause and whether binutils or libvirt will need
changing.

   https://bugzilla.redhat.com/show_bug.cgi?id=1889763

Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>


post-partem


Reviewed-by: Laine Stump <laine@xxxxxxxxxx>


(I had been waiting for my CI to complete too :-)


---
  libvirt.spec.in | 7 +++++++
  1 file changed, 7 insertions(+)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index 325566f329..2a4324b974 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -990,6 +990,13 @@ Libvirt plugin for NSS for translating domain names into IP addresses.
  %autosetup -S git_am
%build
+
+%if 0%{?fedora} == 34
+    # binutils change in F34 broke linking of tests
+    # https://bugzilla.redhat.com/show_bug.cgi?id=1889763
+    %define _lto_cflags %{nil}
+%endif
+
  %if ! %{supported_platform}
  echo "This RPM requires either Fedora >= %{min_fedora} or RHEL >= %{min_rhel}"
  exit 1





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux