On Thu, Feb 11, 2010 at 04:43:53PM +0100, Jiri Denemark wrote:
> Signed-off-by: Jiri Denemark <jdenemar@xxxxxxxxxx>
> ---
> src/cpu/cpu_x86.c | 87 ++++++++++++++++++++++++++++++++++++++++++++++++++++-
> 1 files changed, 86 insertions(+), 1 deletions(-)
>
> diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c
> index a6db86d..2194c32 100644
> --- a/src/cpu/cpu_x86.c
> +++ b/src/cpu/cpu_x86.c
> @@ -137,6 +137,17 @@ x86cpuidClearBits(struct cpuX86cpuid *cpuid,
> }
>
>
> +static inline void
> +x86cpuidAndBits(struct cpuX86cpuid *cpuid,
> + const struct cpuX86cpuid *mask)
> +{
> + cpuid->eax &= mask->eax;
> + cpuid->ebx &= mask->ebx;
> + cpuid->ecx &= mask->ecx;
> + cpuid->edx &= mask->edx;
> +}
> +
Minor point ...
Why forcing to inline and hence inflate code size and confuse
debuggers ? That doesn't sound a time critical operation, isn't it ?
True for other inlined functions in that module though ...
ACK,
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list