Re: [PATCH 7/9] util: remove unneeded cleanup:/ret in virpci.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 20, 2020 at 10:26:07PM -0400, Laine Stump wrote:
> These were nops once enough cleanup was g_auto'd.
> 
> Signed-off-by: Laine Stump <laine@xxxxxxxxxx>
> ---

Probably not as trivial as the removal of the ones below, but IMO it would
still be straightforward to also drop the cleanup label in
virPCIDeviceGetDriverPathAndName. All is needed is not to touch the caller
provided pointer until the very last moment you'd do a g_steal.
Perhaps a candidate for a standalone patch, your call.

Reviewed-by: Erik Skultety <eskultet@xxxxxxxxxx>




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux