On 12.10.20 19:43, Andrey Shinkevich wrote:
> Provide API for the COR-filter insertion/removal.
> Also, drop the filter child permissions for an inactive state when the
> filter node is being removed.
>
> Signed-off-by: Andrey Shinkevich <andrey.shinkevich@xxxxxxxxxxxxx>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@xxxxxxxxxxxxx>
> ---
> block/copy-on-read.c | 88 ++++++++++++++++++++++++++++++++++++++++++++++++++++
> block/copy-on-read.h | 35 +++++++++++++++++++++
> 2 files changed, 123 insertions(+)
> create mode 100644 block/copy-on-read.h
>
> diff --git a/block/copy-on-read.c b/block/copy-on-read.c
> index cb03e0f..bcccf0f 100644
> --- a/block/copy-on-read.c
> +++ b/block/copy-on-read.c
[...]
> @@ -159,4 +188,63 @@ static void bdrv_copy_on_read_init(void)
> bdrv_register(&bdrv_copy_on_read);
> }
>
> +
> +BlockDriverState *bdrv_cor_filter_append(BlockDriverState *bs,
> + QDict *node_options,
> + int flags, Error **errp)
I had hoped you could make this a generic block layer function. :(
(Because it really is rather generic)
*shrug*
Reviewed-by: Max Reitz <mreitz@xxxxxxxxxx>
> +{
> + BlockDriverState *cor_filter_bs;
> + Error *local_err = NULL;
> +
> + cor_filter_bs = bdrv_open(NULL, NULL, node_options, flags, errp);
> + if (cor_filter_bs == NULL) {
> + error_prepend(errp, "Could not create COR-filter node: ");
> + return NULL;
> + }
> +
> + if (!qdict_get_try_str(node_options, "node-name")) {
> + cor_filter_bs->implicit = true;
> + }
> +
> + bdrv_drained_begin(bs);
> + bdrv_replace_node(bs, cor_filter_bs, &local_err);
> + bdrv_drained_end(bs);
> +
> + if (local_err) {
> + bdrv_unref(cor_filter_bs);
> + error_propagate(errp, local_err);
> + return NULL;
> + }
> +
> + return cor_filter_bs;
> +}
Attachment:
signature.asc
Description: OpenPGP digital signature
