IMO "return-pages" sounds the best out of those and stays relatively consistent with the kernel and qemu terminology for this feature.
I personally don't see a huge problem with the current name, but I've also been staring at the words "free page reporting" for too long.
Cheers!
-- Nico
On Wed, Oct 14, 2020 at 1:56 AM Michal Privoznik <mprivozn@xxxxxxxxxx> wrote:
On 10/13/20 7:57 PM, Peter Krempa wrote:
> On Tue, Oct 13, 2020 at 18:47:39 +0200, Michal Privoznik wrote:
>> On 10/13/20 5:10 PM, Michal Privoznik wrote:
>>> On 10/13/20 1:35 AM, Nico Pache wrote:
>>>> gitlab issue: https://gitlab.com/libvirt/libvirt/-/issues/79
>>>>
>>>> The virtio-balloon device now has the ability to report free pages
>>>> back to the hypervisor for reuse by other programs.
>>
>> Is this something that we might want to report? I mean, we have 'virsh
>> dommemstat $dom' which under the hood calls:
>>
>> {"execute":"qom-get","arguments":{"path":"/machine/peripheral/balloon0","property":"guest-stats"},"id":"libvirt-400"}
>
> As I've pointed out in earlier review, I think that the feature name is
> a bit misleading. It sounds like a statistic, not something that
> actually returns memory to the host. The docs are now better but still
> leave a lot of room for imagination.
>
> IMO, if the feature is mainly for returning memory to the host, the
> 'reporting' word should not have been used.
>
Oh sorry I missed that. I a penance I will post a cleanup patch. How
does "free-pages" or "return-pages" or even "discard-pages" sound?
Michal
