Re: [libvirt PATCH 0/4] vmx: start parsing SATA disks

Michal Privoznik <mprivozn@xxxxxxxxxx> · Tue, 13 Oct 2020 15:22:20 +0200

On 10/12/20 5:13 PM, Pino Toscano wrote:
Try to parse SATA disks in VMware guests from their configs in VMX
files. There are a couple of helper/cleanup commits to ease a bit the
actual patches.

Pino Toscano (4):
   vmx: hide private helpers
   vmx: shortcut 'cdrom-image' as CD-ROM earlier
   vmx: expand the disk array
   vmx: start parsing SATA disks

  src/libvirt_vmx.syms                          |  12 -
  src/vmx/vmx.c                                 | 212 ++++++++++++++++--
  src/vmx/vmx.h                                 |  44 ----
  .../vmx2xml-esx-in-the-wild-10.vmx            | 101 +++++++++
  .../vmx2xml-esx-in-the-wild-10.xml            |  36 +++
  .../vmx2xmldata/vmx2xml-esx-in-the-wild-8.xml |   6 +
  tests/vmx2xmltest.c                           |   1 +
  7 files changed, 335 insertions(+), 77 deletions(-)
  create mode 100644 tests/vmx2xmldata/vmx2xml-esx-in-the-wild-10.vmx
  create mode 100644 tests/vmx2xmldata/vmx2xml-esx-in-the-wild-10.xml

Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx>

Michal