On a Monday in 2020, Pavel Hrdina wrote:
Our libvirt-dbus tests discovered allocation issues introduced by recent rewrite to use g_new0 instead of VIR_ALLOC_N by allocating array one element shorter in some places which can lead to crashes of client applications counting on a fact that the returned arrays are NULL terminated.
Oops, I did not notice that my vim macro [0] dropped these (due to looking for the ')' from the left side). There seem to be no other cases like this in my changes where the expression contains a parenthesis. Thanks for fixing this. Jano
Pavel Hrdina (2): conf: fix g_new0 allocation conf: virsecretobj: fix g_new0 allocation src/conf/virinterfaceobj.c | 2 +- src/conf/virnetworkobj.c | 4 ++-- src/conf/virnodedeviceobj.c | 2 +- src/conf/virsecretobj.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-)
[0] I was not able to replace everything with Coccinelle
Attachment:
signature.asc
Description: PGP signature
