Re: [libvirt PATCH 00/15] various meson fixes and improvements

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2020-10-08 at 15:58 +0200, Pavel Hrdina wrote:
> Pavel Hrdina (15):
>   meson_options: change VMware default from enabled to auto
>   meson_options: change VirtualBox default from enabled to auto
>   meson_options: move firewalld options to build feature options
>   meson: no need to call meson.get_compiler() again
>   meson: properly handle libpcap if it's explicitly disabled
>   meson: properly handle readline if it's explicitly disabled
>   meson: build nodedev driver only if libvirtd is compiled
>   meson: add libnl build option
>   meson: add rbd build option
>   meson: prefix kvm_dep, m_dep and util_dep with lib
>   meson: add missing libraries to summary
>   meson: remove required libraries from summary
>   meson: move build feature options to miscellaneous summary
>   meson: add docs option to enable/disable generating documentation
>   meson: add tests build option to enable/disable unit tests
> 
>  libvirt.spec.in       |   2 +
>  meson.build           | 135 +++++++++++++++++++++++++-----------------
>  meson_options.txt     |  12 ++--
>  src/bhyve/meson.build |   4 +-
>  src/util/meson.build  |   4 +-
>  5 files changed, 96 insertions(+), 61 deletions(-)

I've added a few minor comments to individual patches, but regardless
of how you decide to address those the series gets a

  Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>

-- 
Andrea Bolognani / Red Hat / Virtualization




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux