On a Monday in 2020, Daniel P. Berrangé wrote:
On Mon, Oct 05, 2020 at 12:21:45AM +0200, Ján Tomko wrote:This number is the closest multiple of 100000000^^^ Huh ?
0x100 for short
above the largest frame value reported by clang in the current codebase. Signed-off-by: Ján Tomko <jtomko@xxxxxxxxxx> --- meson.build | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/meson.build b/meson.build index a5ce8e17a8..8bef701f67 100644 --- a/meson.build +++ b/meson.build @@ -419,10 +419,9 @@ cc_flags += [ # but need to rewrite various areas of code first '-Wno-format-truncation', - # This should be < 256 really. Currently we're down to 4096, - # but using 1024 bytes sized buffers (mostly for virStrerror) - # stops us from going down further - '-Wframe-larger-than=4096', + # This should be < 256 really.I think we can drop this as I doubt it is worth trying to achieve. We've not knowingly had stack overflow in livirt in history.
Yeah, 256 is impossible to achieve. Especially since clang seems more conservative with the numbers it prints. I merely deleted the parts of the comment with outdated information. Jano
+ # Using 1024 bytes sized buffers stops us from going down further + '-Wframe-larger-than=1792',Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
Attachment:
signature.asc
Description: PGP signature
