On Oct 2, 2020, at 2:48 AM, Pino Toscano <ptoscano@xxxxxxxxxx> wrote: > IMHO these explanations should be documented in the Hyper-V driver > page: docs/drvhyperv.html.in. This way, users know about the different > value returned by virConnectGetVersion() by the Hyper-V driver, and > can unmangle it to get the real Hyper-V version. You’re absolutely right. I’ll add some documentation about this. Would you prefer it as a separate commit or included with the code changes? > Considering the major, minor and micro parts of the version string are > already broken out here, why not directly encode the version number as > long? It seems a forced roundtrip to format it as string, and parse it > again. I agree that it's extra work. I was being careful and wanted to ensure that all of the existing error handling in virParseVersionString() still occurred. After looking it over again, I was being excessively cautious and will change it to just produce the unsigned long. -- Matt
