Re: [PATCH 0/9] various build flag related fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/1/20 1:14 AM, Laine Stump wrote:
These patches eliminate a few build flags that were necessary back 10
years ago when their associated features had been newly added to the
kernel, but are now pointless (because all supported Linuxes have the
feature) (1-6), makes it possible to to a successful (and usable,
albeit limited in some ways) build on a system that doesn't have
libnl3-devel installed (7-8) (macvtap and interface type='hostdev'
don't work, but standard tap devices do), and removes a duplicated
identifier check that I noticed in meson.build (9).

Laine Stump (9):
   util: remove useless check for IFLA_VF_MAX
   util: remove extraneous defined(__linux__) when checking for
     WITH_LIBNL
   build: eliminate useless WITH_VIRTUALPORT check
   build: remove check for MACVLAN_MODE_PASSTHRU
   build: simplify check for WITH_MACVTAP
   build: eliminate WITH_MACVTAP flag
   util: fix Linux build when libnl-devel isn't available
   util: provide non-netlink/libnl alternative for virNetDevGetMaster()
   build: remove duplicate check for GET_VLAN_VID_CMD

  libvirt.spec.in                  |  1 -
  meson.build                      | 30 ------------------------
  src/util/virnetdev.c             | 40 ++++++++++++++++++++++++++------
  src/util/virnetdevbridge.c       |  6 ++---
  src/util/virnetdevip.c           |  6 ++---
  src/util/virnetdevmacvlan.c      | 11 +++------
  src/util/virnetdevvportprofile.c |  8 +++----
  src/util/virnetlink.c            |  4 ++--
  src/util/virnetlink.h            |  4 ++--
  tools/virsh.c                    |  3 ---
  10 files changed, 50 insertions(+), 63 deletions(-)


Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx>

Michal




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux