Andrea Bolognani wrote: > On Thu, 2020-09-24 at 20:18 +0400, Roman Bogorodskiy wrote: > > +<p>Note: VNC password authentication is known to be cryptographically weak. > > +Additionally, the password is passed as a command line argument in clear text. > > +Make sure you understand the risks associated with this feature before using it.</p> > > Great warning :) > > > +<h3><a id="sound">Sound device</a></h3> > > + > > +<p>As of <a href="https://svnweb.freebsd.org/changeset/base/349355">r349355</a> bhyve > > +supports sound device emulation. > > Is this changeset part of any FreeBSD release yet? If so, I would use > its version number here; if not, at least clarify it by saying "as of > [FreeBSD changeset r349355]" or something like that. It's not part of any released version. It'll be available with FreeBSD 13.0-RELEASE, which is planned to be released next year. > With the link text tweaked, > > Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx> Thanks. I'll fix this link and will push the change as it should be safe for the freeze. Also, this document has a number of other similarly formatted links. I'll update those in a separate patch, along with some other nits I noticed. > -- > Andrea Bolognani / Red Hat / Virtualization > Roman Bogorodskiy
Attachment:
signature.asc
Description: PGP signature