On Thu, Sep 24, 2020 at 01:43:54PM +0200, Peter Krempa wrote:
> Remove the overlay if the disk was <transient/>. Note that even if we'd
> forbid unplug of such a disk through the API, the disk can still be
> ejected from the guest.
>
> Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
> ---
> src/qemu/qemu_hotplug.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
> index ed4d1580fa..11b549b12b 100644
> --- a/src/qemu/qemu_hotplug.c
> +++ b/src/qemu/qemu_hotplug.c
> @@ -4313,6 +4313,15 @@ qemuDomainRemoveDiskDevice(virQEMUDriverPtr driver,
> qemuHotplugRemoveManagedPR(driver, vm, QEMU_ASYNC_JOB_NONE) < 0)
> goto cleanup;
>
> + if (disk->transient) {
> + VIR_DEBUG("Removing transient overlay '%s' of disk '%s'",
> + disk->src->path, disk->dst);
> + if (qemuDomainStorageFileInit(driver, vm, disk->src, NULL) >= 0) {
> + virStorageFileUnlink(disk->src);
> + virStorageFileDeinit(disk->src);
> + }
> + }
> +
> ret = 0;
>
> cleanup:
> --
Tested-by: Masayoshi Mizuma <m.mizuma@xxxxxxxxxxxxxx>
Thanks a lot!
Masa
