On Wed, Sep 23, 2020 at 12:46 PM Jim Fehlig <jfehlig@xxxxxxxx> wrote: > > On 9/23/20 7:51 AM, Jim Fehlig wrote: > > On 9/23/20 7:26 AM, Christian Ehrhardt wrote: > >> On Wed, Sep 23, 2020 at 12:35 AM Jim Fehlig <jfehlig@xxxxxxxx> wrote: > >>> > >>> Like other distros, openSUSE Tumbleweed recently changed libexecdir from > >>> /usr/lib to /usr/libexec. Add it as an allowed path for libxl-save-helper > >>> and pygrub. > >> > >> Hi Jim, > >> ack to the intention, but I think since this should use @libexecdir@ I think. > >> Or did anything change that this doesn't apply anymore ... in that > >> case I beg your pardon. > >> > >> [1]: > >> https://libvirt.org/git/?p=libvirt.git;a=commit;h=5c8bd31c881e99261ac098e867a79b300440731a > >> > > > > Heh, I see that skipped over the xen stuff :-). I'll send a V2 later. > > Thinking about it more, perhaps it is best to go with this V1 patch since these > are not files provided by libvirt but xen, where conceivably libvirt and xen > could be built with different libexecdir? IMO it would be best to explicitly > list the known paths distros have used for libxl-save-helper and pygrub. > It is entirely possible that one has not been updated yet, or someone is mixing packages, so this patch makes sense over having it assume a specific path. -- 真実はいつも一つ！/ Always, there's only one truth!
