On a Monday in 2020, Pavel Hrdina wrote:
We used to check the format of reply data with libdbus so we should do the same with GLib DBus as well. Signed-off-by: Pavel Hrdina <phrdina@xxxxxxxxxx> --- At first I thought that this is not necessary as it is unlikely to happen but after Jano found the bug with firewalld getZones function and asked about checking return values I figured out that it will be better to check it because if the returned message would have different format it would be silently ignored. src/rpc/virnetdaemon.c | 1 + src/util/virfirewalld.c | 5 +++++ src/util/virgdbus.c | 8 ++++++-- src/util/virgdbus.h | 2 ++ src/util/virpolkit.c | 1 + src/util/virsystemd.c | 7 +++++++ 6 files changed, 22 insertions(+), 2 deletions(-)
Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx> Jano
Attachment:
signature.asc
Description: PGP signature
