On Tue, 2020-09-22 at 09:29 -0300, Daniel Henrique Barboza wrote: > Hi, > > This is a follow up of [1] after Andrea pushed the revert > patch as standalone. > > Changes from v1: > - patch 2 (former 3): moved the auto-align code from > virDomainMemoryDefParseXML() to virDomainMemoryDefPostParse() > - patch 3 (former 4): updated NEWS.rst based on Andrea's > changes already upstream > > > [1] https://www.redhat.com/archives/libvir-list/2020-September/msg00864.html > > Daniel Henrique Barboza (3): > conf, qemu: move qemuDomainNVDimmAlignSizePseries to domain_conf.c > domain_conf.c: auto-align pSeries NVDIMM in > virDomainMemoryDefPostParse() > NEWS.rst: update NVDIMM changes entry Looks good! Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx> Can you please confirm your GitLab account is 'danielhb'? I would like to add you to the libvirt organization so that you can start pushing your own patches instead of relying on someone else doing that for you. -- Andrea Bolognani / Red Hat / Virtualization
