On Tue, Sep 22, 2020 at 04:28:48PM +0400, Roman Bogorodskiy wrote: > From: Fabian Freyer <fabian.freyer@xxxxxxxxxxxxxxxxxxx> > > Add a new helper function, bhyveParsePCIFbuf, to parse the bhyve-argv > parameters for a frame-buffer device to <graphics/> and <video/> > definitions. > > For now, only the listen address, port, and vga mode are detected. > Unsupported parameters are silently skipped. > > This involves upgrading the private API to expose the > virDomainGraphicsDefNew helper function, which is used by > bhyveParsePCIFbuf. > > Signed-off-by: Fabian Freyer <fabian.freyer@xxxxxxxxxxxxxxxxxxx> > Signed-off-by: Roman Bogorodskiy <bogorodskiy@xxxxxxxxx> > --- > src/bhyve/bhyve_parse_command.c | 91 ++++++++++++++++++- > src/libvirt_private.syms | 1 + > .../bhyveargv2xml-vnc-listen.args | 10 ++ > .../bhyveargv2xml-vnc-listen.xml | 22 +++++ > .../bhyveargv2xml-vnc-vga-io.args | 10 ++ > .../bhyveargv2xml-vnc-vga-io.xml | 22 +++++ > .../bhyveargv2xml-vnc-vga-off.args | 10 ++ > .../bhyveargv2xml-vnc-vga-off.xml | 23 +++++ > .../bhyveargv2xml-vnc-vga-on.args | 10 ++ > .../bhyveargv2xml-vnc-vga-on.xml | 23 +++++ > .../bhyveargv2xmldata/bhyveargv2xml-vnc.args | 10 ++ > tests/bhyveargv2xmldata/bhyveargv2xml-vnc.xml | 22 +++++ > tests/bhyveargv2xmltest.c | 5 + > 13 files changed, 258 insertions(+), 1 deletion(-) > create mode 100644 tests/bhyveargv2xmldata/bhyveargv2xml-vnc-listen.args > create mode 100644 tests/bhyveargv2xmldata/bhyveargv2xml-vnc-listen.xml > create mode 100644 tests/bhyveargv2xmldata/bhyveargv2xml-vnc-vga-io.args > create mode 100644 tests/bhyveargv2xmldata/bhyveargv2xml-vnc-vga-io.xml > create mode 100644 tests/bhyveargv2xmldata/bhyveargv2xml-vnc-vga-off.args > create mode 100644 tests/bhyveargv2xmldata/bhyveargv2xml-vnc-vga-off.xml > create mode 100644 tests/bhyveargv2xmldata/bhyveargv2xml-vnc-vga-on.args > create mode 100644 tests/bhyveargv2xmldata/bhyveargv2xml-vnc-vga-on.xml > create mode 100644 tests/bhyveargv2xmldata/bhyveargv2xml-vnc.args > create mode 100644 tests/bhyveargv2xmldata/bhyveargv2xml-vnc.xml Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
