On Wed, Sep 09, 2020 at 03:38:21PM +0200, Pavel Hrdina wrote: > On Wed, Sep 09, 2020 at 02:31:48PM +0100, Daniel P. Berrangé wrote: > > On Wed, Sep 09, 2020 at 03:10:06PM +0200, Andrea Bolognani wrote: > > > The default timeout for tests is 30s, but that's not always > > > enough time: the Valgrind test, for example, are currently > > > special-cased because they take longer, and on certain > > > architectures where powerful hardware is not (yet) available > > > even the basic test programs might take more than 30s to > > > complete. > > > > Does Meson not have a standard way to increase the default > > timeout globally ? It feels like this scenario of building > > on slow hardware could hit any application, so surprised > > we need to add our own args for this > > It does but only if using meson command: > > meson test -t > > if the tests are started using ninja command: > > ninja test > > it is not possible to pass additional arguments to meson via ninja. So unless there's a blocker preventing use of "meson test -t" then it seems we don't need this patch. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
