On Fri, Aug 28, 2020 at 10:08:34 -0400, Masayoshi Mizuma wrote:
> From: Masayoshi Mizuma <m.mizuma@xxxxxxxxxxxxxx>
>
> Block blockjobs when transient disk option is enabled so far.
>
> Signed-off-by: Masayoshi Mizuma <m.mizuma@xxxxxxxxxxxxxx>
> ---
> src/qemu/qemu_domain.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
> index e28f704dba..98a52e5476 100644
> --- a/src/qemu/qemu_domain.c
> +++ b/src/qemu/qemu_domain.c
> @@ -10678,6 +10678,13 @@ qemuDomainDiskBlockJobIsSupported(virDomainObjPtr vm,
> return false;
> }
>
> + if (disk->transient) {
> + virReportError(VIR_ERR_OPERATION_UNSUPPORTED,
> + _("block jobs are not supported on transient disk '%s'"),
> + disk->dst);
> + return false;
> + }
Please move this patch a bit sooner in the series so that all checks are
in place before enabling the feature.
