On Mon, Sep 07, 2020 at 15:41:34 +0200, Andrea Bolognani wrote: > On Mon, 2020-09-07 at 14:42 +0200, Peter Krempa wrote: > > On Thu, Sep 03, 2020 at 02:56:48 +0000, Yanqiu Zhang wrote: > > > + * qemu: Support TLS for NBD connections for pull mode backup > > > + > > > + Use the configured TLS env to setup encryption of the TLS transport. Add 'tls' > > > + attribute for 'server' element to enable tls. Possible values are ``yes`` > > > + or ``no``. > > > > Incremental backup is not enabled yet, so there's no real point in > > documenting patches implementing parts of it. > > > > NACK > > Makes sense... Unfortunately the patch has been pushed already. Do > you want me to revert it? Do you want to do that yourself? Sure, here's the patch: https://www.redhat.com/archives/libvir-list/2020-September/msg00349.html I've specifically also mentioned before that I don't see a point in documenting stuff for incremental backup: https://www.redhat.com/archives/libvir-list/2020-July/msg00267.html